Skip to content

Create AnyBaseToAnyBase #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2017
Merged

Conversation

RollandMichael7
Copy link
Contributor

Class for converting a number between any two bases, by going through decimal.

Class for converting a number between any two bases, by going through decimal.
@dynamitechetan
Copy link
Member

file name does not end in .java

@varunu28 varunu28 merged commit 19053d0 into TheAlgorithms:master Oct 10, 2017
@varunu28
Copy link
Contributor

@RollandMichael7 Thanks for the commit. Just a heads up that the code doesn't handles a case where I enter a number of wrong base. We can have a check if the number being input by the user is actually in the correct beginning base
Ex:
Enter number: 1104
Enter beginning base: 2
Enter end base: 10
16

This should prompt the user with an error

We can look for this functionality in future. I will also think about a method to handle this case
Thanks 👍

@RollandMichael7
Copy link
Contributor Author

Thanks for pointing that out!

I have an idea about how to handle that. I'll make a pull request by the end of the day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants